-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for 'ipfs config replace' #3073
Conversation
c23d95e
to
27cc473
Compare
@@ -81,8 +94,6 @@ test_config_cmd() { | |||
test_cmp ident_exp ident_out | |||
' | |||
|
|||
# SECURITY | |||
# Those tests are here to prevent exposing the PrivKey on the network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whyd you remove this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nvm, i see that you moved it up
Can you maybe break that test up a little bit? maybe into a setup step, the command execution, and the output check? |
@Kubuxu any update here? |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
27cc473
to
2a2e3eb
Compare
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
How does it look now? |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
539af92
to
25a035f
Compare
Much better, except you've angered the mighty travis CI. |
5850819
to
02880e0
Compare
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
02880e0
to
92d1d65
Compare
@whyrusleeping OSX/BSD sed is behaving quite strangely with //cc @chriscool |
@Kubuxu I think it is better to just avoid using the -i option when using sed.
|
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
It looks like there are still sed related problems:
|
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
73f977d
to
5b4a6ea
Compare
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
It works, Shanress on OSX passed, I will squash everything. |
LGTM, thanks @Kubuxu and @chriscool :) |
No description provided.