Extract dht, kbucket, routing, record, testutils, etc. [work-in-progress] #3185
Conversation
License: MIT Signed-off-by: George Antoniadis <george@noodles.gr>
License: MIT Signed-off-by: George Antoniadis <george@noodles.gr>
License: MIT Signed-off-by: George Antoniadis <george@noodles.gr>
| // TODO(geoah) Move to ./testutils or somewhere else | ||
| func ThreadSafeCloserMapDatastore() ThreadSafeDatastoreCloser { | ||
| return CloserWrap(syncds.MutexWrap(datastore.NewMapDatastore())) | ||
| } |
There was a problem hiding this comment.
This is the ThreadSafeCloserMapDatastore I'm talking about.
Originally this was under thirdparty/testutils/datastore.go but as there was no other reason for go-testutils to depend on go-datastore it was removed.
I have temporarily put it under thirdparty/datastore2 but I'm open to suggestions.
There was a problem hiding this comment.
Thats fine with me. The more we break things out the easier it will become to find homes for these sorts of things.
whyrusleeping
added
help wanted
|
Looks like we need to delete blocks/key, routing/{dht,kbucket,record} and maybe a few others too, and then we should actually use these new extracted packages 📦 |
License: MIT Signed-off-by: George Antoniadis <george@noodles.gr>
|
@whyrusleeping not sure why the packages were still there. I have now actually removed the packages. I think I got them all? |
|
Closing this in favour or more, smaller PRs. |
This is a direct continuation of the work done to separate the dht package. It replaces various packages with external ones.
Once libp2p/go-libp2p-kad-dht#6 is merged, there a couple more stuff to do and this should be merge-able as well.
ThreadSafeCloserMapDatastore