Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Basic Filestore implementation. #3368

Closed
wants to merge 1 commit into from
Closed

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Nov 8, 2016

@whyrusleeping this is not 100% what you want but it is close. It still uses bits of the multi-blockstore but doesn't use any of the parts you don't like.

Things that still need to be done (for this part):

  • Implement DeleteBlock for the filestore
  • Config option to enable filestore (it is now always enabled due to the complete remove of ipfs filestore commands, including ipfs filestore enable)
  • Implement a correct Has method that checks to make sure the content is still available

Things you may still not like:

  • "ipfs add" will not add blocks if any of them happen to be in the filestore

Things I don't like:

  • way to many, most of which needs to be in separate issues.

Others: see #2634 for the full implementation.

@kevina kevina added this to the Filestore implementation milestone Nov 8, 2016
@kevina kevina added the status/in-progress In progress label Nov 8, 2016
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@whyrusleeping
Copy link
Member

@jbenet You mentioned the other day that you wanted to review this. If you find time soon to do so that would be great.

@kevina
Copy link
Contributor Author

kevina commented Nov 21, 2016

@jbenet I am not sure what @whyrusleeping told you but please note that this is only a small fraction of the full filestore code with very little of the functionality of #2634. I do not consider this very useful, as it doesn't even provide a way to list what is in the filestore. We also had some rather strong disagreements that I have not been able to write (publicly) about yet.

The test cases are also not as comprehensives as I would like as most of the test cases rely on functionality not in this pull request.

@whyrusleeping
Copy link
Member

#3629 was merged in favor of this one.Closing now

@whyrusleeping whyrusleeping removed the status/ready Ready to be worked label Mar 6, 2017
@whyrusleeping whyrusleeping deleted the kevina/filestore-basic branch March 6, 2017 10:41
@kevina kevina restored the kevina/filestore-basic branch March 6, 2017 19:30
@kevina
Copy link
Contributor Author

kevina commented Mar 6, 2017

@Kubuxu can we move the branch kevina/filestore-basic to go-ipfs-archived?

@Kubuxu
Copy link
Member

Kubuxu commented Mar 6, 2017

It will be moved in a month.

@Kubuxu Kubuxu deleted the kevina/filestore-basic branch August 10, 2017 17:10
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants