Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make raw leaves work with 'ipfs get' #3757

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Conversation

whyrusleeping
Copy link
Member

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@whyrusleeping whyrusleeping added the status/in-progress In progress label Mar 7, 2017
@whyrusleeping
Copy link
Member Author

For some reason the filestore tests on OSX are failing: https://s3.amazonaws.com/archive.travis-ci.org/jobs/208472671/log.txt

Looks like an issue with the 'check repo size' stuff

@Kubuxu Kubuxu self-requested a review March 7, 2017 10:49

res.SetLength(size)
case *dag.RawNode:
res.SetLength(uint64(len(dn.RawData())))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me think that we should have sort of Size method or better unixfs interface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unixfs interfaces would and will be nice

@Kubuxu Kubuxu added this to the Ipfs 0.4.7 milestone Mar 7, 2017
@whyrusleeping whyrusleeping merged commit eca0d1c into master Mar 7, 2017
@whyrusleeping whyrusleeping deleted the fix/get-raw-leaves branch March 7, 2017 23:40
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants