Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply the megacheck code vetting tool for idiomatic go #3949

Merged
merged 7 commits into from
Jun 7, 2017
Merged

apply the megacheck code vetting tool for idiomatic go #3949

merged 7 commits into from
Jun 7, 2017

Commits on May 31, 2017

  1. introduce 'make megacheck' 

    License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed May 31, 2017
    Configuration menu
    Copy the full SHA
    f9ba45d View commit details
    Browse the repository at this point in the history

  2. apply the megacheck tool to improve code quality 

    License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed May 31, 2017
    Configuration menu
    Copy the full SHA
    c5df8f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2017

  1. address PR comments; remove commented/dead code 

    License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    096b323 View commit details
    Browse the repository at this point in the history

  2. codeclimate: use only 4/5 defaults 

    because context.TODO() is a legit function

License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    0b58458 View commit details
    Browse the repository at this point in the history

  3. make: use correct location for [test_go_megacheck] 

    License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    ae4cad3 View commit details
    Browse the repository at this point in the history

  4. hamt: reinstate a useful debug function 

    License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    b77d5aa View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2017

  1. bugfix: copy the correct variable 

    License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
    @zramsay
    zramsay committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    6c064d1 View commit details
    Browse the repository at this point in the history