Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure non-self keys also get republished #3951

Merged
merged 2 commits into from
Jun 10, 2017
Merged

Make sure non-self keys also get republished #3951

merged 2 commits into from
Jun 10, 2017

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Jun 1, 2017 •
edited
Loading

Closes #3808

@kevina kevina added the status/in-progress In progress label Jun 1, 2017
This was referenced Jun 1, 2017
Closed
Closed
@whyrusleeping
Copy link
Member

👍 i really like the approach. Will make it easy when we migrate to having the primary identity key in the keystore.

@kevina
Copy link
Contributor Author

kevina commented Jun 3, 2017

@whyrusleeping thanks, do you want me to go ahead and rebase and squash this?

@whyrusleeping
Copy link
Member

@kevina yeah, i'd go ahead and move forward here

@kevina kevina changed the title Super WIP: Make sure non-self keys also get republished Make sure non-self keys also get republished Jun 7, 2017
@kevina
Copy link
Contributor Author

kevina commented Jun 7, 2017

@whyrusleeping rebased and squashed.

@kevina
repub: iterate through all keys in keystore
d674dd7 
Iterate through all keys in the keystore so keys added with
"ipfs key gen" behave the same as the <self> key.  Don't maintain a
separate repub list as it does not really serve a purpose at this
point in time.  See #3808.

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
whyrusleeping
whyrusleeping approved these changes Jun 9, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Would enjoy finding a way to avoid those long sleeps in the tests, but thats out of scope here.

@whyrusleeping whyrusleeping requested a review from Kubuxu June 9, 2017 03:49
@kevina
Copy link
Contributor Author

kevina commented Jun 9, 2017

@whyrusleeping I made one last tweak. I kept it is a separate commit so you can see what is changed. I can squash it if you want.

@whyrusleeping
Copy link
Member

@kevina as far as i can tell, entrylock is no longer used either. Good catch

@kevina
repub: remove unused field
1fe6e18 
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@whyrusleeping
Copy link
Member

Thanks @kevina :)

@whyrusleeping whyrusleeping merged commit 10f9e77 into master Jun 10, 2017
@whyrusleeping whyrusleeping deleted the kevina/repub branch June 10, 2017 17:17
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevina @whyrusleeping