Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godeps: remove go-random* #3965

Closed
wants to merge 1 commit into from
Closed

Godeps: remove go-random* #3965

wants to merge 1 commit into from

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Jun 8, 2017

  • works toward Migrating away from Godeps #2722
  • of the two packages published to gx, one may need to be re-published (I don't fully understand the gx/gx-go pipeline yet). To what extent is Publish to gx jbenet/go-random-files#2 required?
  • keeping it small for now though definitely keen to get Godeps out of this repo & will make bigger PRs if this one is 👍

@zramsay
Copy link
Contributor Author

zramsay commented Jun 8, 2017

the repos put from gx remained available on the public gateway, though I've pinned them now and the CI should be able to get them. Does opening and closing a PR re-trigger the CI or do I have to push new commits?

@zramsay zramsay closed this Jun 8, 2017
@zramsay zramsay reopened this Jun 8, 2017
@magik6k
Copy link
Member

magik6k commented Jun 8, 2017

You can do git commit --amend+git push -f to re-trigger

License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
@whyrusleeping
Copy link
Member

@zramsay it seems the go-random package that is gx vendored here is missing some dependencies or something. @Kubuxu can you take a look here?

@Kubuxu
Copy link
Member

Kubuxu commented Jun 9, 2017

You have published the package of go-random in weird state (with references to itself rewritten with some other version).

Make sure that imports in it are not rewritten (gx-go uw), and then publish it.

@Kubuxu
Copy link
Member

Kubuxu commented Jun 9, 2017

@zramsay zramsay closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants