Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocks: move block format to it's own repo #3990

Closed
wants to merge 4 commits into from

Conversation

Stebalien
Copy link
Member

We need to reference it from outside of this repo (namely, from go-ipld-format).

@Stebalien
Copy link
Member Author

I believe /ipfs/QmeK8xFAXx4GBpZG6mizck1XAunVtxP8Tmvir5FMwp5MYb needs to be pinned for this to build.

@Stebalien Stebalien closed this Jun 19, 2017
@Stebalien Stebalien reopened this Jun 19, 2017
@Stebalien Stebalien force-pushed the extract-block branch 2 times, most recently from 07a8ca5 to 3315b91 Compare June 20, 2017 01:03
@Stebalien
Copy link
Member Author

Depends on ipfs/go-ipld-cbor#14 (due to dependency tree update).

@kevina
Copy link
Contributor

kevina commented Jun 28, 2017

I don't like little repos with such a small about of code, but maybe its required. If @whyrusleeping is okay with it so am I. A few questions:

(1) Did you change anything in blocks.go other then move the code into its own repo?

(2) Is the moved code in a repo under ipfs. It likely should be, as a member you should have permission to create a new repo and I am sure @whyrusleeping will be okay with it,

(3) Where did the name go-block-format come from.

@whyrusleeping
Copy link
Member

@kevina yeah, it needs to move outside of go-ipfs so other packages can use it without having to import the entirety of this repo.

@Stebalien
Copy link
Member Author

Did you change anything in blocks.go other then move the code into its own repo?

Nope. I also kept the commit history intact at @whyrusleeping's requrest (although obviously the hashes have changed).

Is the moved code in a repo under ipfs. It likely should be, as a member you should have permission to create a new repo and I am sure @whyrusleeping will be okay with it,

Yes. https://github.com/ipfs/go-block-format/

Where did the name go-block-format come from.

I chose it to match go-ipld-format; it serves the same purpose but for blocks. I considered just adding it to go-ipld-format but one should be able to implement block storage and exchange systems without understanding IPLD.

@Stebalien
Copy link
Member Author

@lgierth I just noticed that this was tried once before (https://github.com/ipfs/go-blocks) and you moved it back into go-ipfs. What was your reasoning?

@Stebalien Stebalien requested a review from a user June 28, 2017 05:36
@kevina
Copy link
Contributor

kevina commented Jun 28, 2017

Okay, assuming the tests are fixed I don't see any problems, this looks very straight forward to me.

These were directly used by go-ipfs but not listed in package.json.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
We need to reference it from outside of this repo.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
And updated related dependencies.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
For some reason, this was referenced but wasn't listed in packages.json.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

I've chatted with lgierth and he has no recollection of what happened here. Furthermore, I see no evidence that this package was ever actually removed from this repo. Therefore, I believe that the ipfs/go-blocks repo just never really got off the ground.

However, I don't believe that re-using that repo is the correct solution as this package isn't supposed to have any real functionality, just interfaces, abstractions, and helper-functions. We may eventually revive the go-blocks repo (and make it depend on this one) but there's no point in doing that until we actually need it.

whyrusleeping added a commit that referenced this pull request Jul 3, 2017
Replace #3990: blocks: move block format to it's own repo
@Stebalien Stebalien deleted the extract-block branch July 12, 2017 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants