Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfiles: do not set gecos field on user add. Set group. #4331

Merged
merged 1 commit into from
Oct 22, 2017
Merged

Dockerfiles: do not set gecos field on user add. Set group. #4331

merged 1 commit into from
Oct 22, 2017

Commits on Oct 20, 2017

  1. Dockerfiles: do not set gecos field on user add. Set group. 

    I think this was unintended: useradd -g sets the gecos field to "100".
Probably we meant to use -G to set the ipfs user group.

-G does not take gids, so it needs to be set by name.
The group with gid 100 is "users".

Additionally, since we install the ca-certificates package
(which is already installed), at least we should attempt to update it
to get the latest version of certs.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
    @hsanjuan
    hsanjuan committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    b57539c View commit details
    Browse the repository at this point in the history