Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx: Update go-datastore to 1.4.0 #4399

Merged
merged 2 commits into from
Dec 3, 2017
Merged

gx: Update go-datastore to 1.4.0 #4399

merged 2 commits into from
Dec 3, 2017

Conversation

@ghost ghost assigned magik6k Nov 19, 2017
@ghost ghost added the status/in-progress In progress label Nov 19, 2017
@magik6k
Copy link
Member Author

magik6k commented Nov 19, 2017

Looks like go-libp2p-interface-connmgr got updated somewhere deeper in the stack, cc @Stebalien

@Stebalien
Copy link
Member

@magik6k yes, I updated it with secio. Would you like me to pull that through first or would you like to try doing that together?

@magik6k
Copy link
Member Author

magik6k commented Nov 20, 2017

@Stebalien If you are updating those dep trees then I guess doing this is one go is probably better. (if you are using gx-workspace you will need to add go-ds-badger to package list as it will get skipped otherwise).

@Stebalien
Copy link
Member

@magik6k I've already updated the entire tree (manually, I was pulling through several packages and fixing bugs on the way up) up to go-ipfs except go-ipfs-cmds. Unfortunately, #3856 is causing problems... ipfs/go-ipfs-cmds#18

@Stebalien
Copy link
Member

I'm pulling through a bunch of libp2p stuff in #4403. After that, this should be much simpler.

@whyrusleeping
Copy link
Member

ping @Stebalien ;)

@Stebalien
Copy link
Member

This should now work.

@whyrusleeping
Copy link
Member

needs a rebase

@Stebalien
Copy link
Member

@whyrusleeping fixed.

magik6k and others added 2 commits December 2, 2017 14:55
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@whyrusleeping whyrusleeping merged commit 2ee18fa into master Dec 3, 2017
@whyrusleeping whyrusleeping deleted the gx/datastore-1.4.0 branch December 3, 2017 04:20
@ghost ghost removed the status/in-progress In progress label Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants