-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gx: update go-multihash #4453
gx: update go-multihash #4453
Conversation
3106035
to
bc5c1bc
Compare
Depends on go 1.9. |
bc5c1bc
to
8d04999
Compare
There's a deadlock somewhere in the commands library now. Reproducible by running |
8d04999
to
41d91f8
Compare
Possibly relevant error:
|
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
41d91f8
to
dfe7ef4
Compare
I couldn't reproduce this error after running these tests for several (4?) hours on repeat. If I had to hazard a guess, I'd say that this was caused by a bug in the HTTP streaming implementation. I'm guessing it returned the final 0 instead of treating it as a length. (reported at #4494) I believe this is ready to merge. |
Wooo! thanks @Stebalien ! |
Blocked on:
Shiny ✨:
cid.NewPrefixV1(cid.DagCBOR, mh.SHA_256).Sum(data)
. (TODO: Make go-ipfs actually use this, it's a lot nicer than constructing these manually).ipfs repo verify
incorrectly reports verify complete when daemon isn't running #4360, Panic on Ctrl-D on ipfs add #4436, return ErrNotFound when resolving commands with valid prefixes go-ipfs-cmds#46, fix deadlock on error go-ipfs-cmds#44