Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx: update go-multihash #4453

Merged
merged 1 commit into from
Dec 15, 2017
Merged

gx: update go-multihash #4453

merged 1 commit into from
Dec 15, 2017

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Dec 4, 2017

Blocked on:

Shiny ✨:

@ghost ghost assigned Stebalien Dec 4, 2017
@ghost ghost added the status/in-progress In progress label Dec 4, 2017
@Stebalien Stebalien force-pushed the gx/update-5osgb9 branch 4 times, most recently from 3106035 to bc5c1bc Compare December 4, 2017 06:58
@Stebalien
Copy link
Member Author

Depends on go 1.9.

@Stebalien
Copy link
Member Author

There's a deadlock somewhere in the commands library now. Reproducible by running t0110-gateway.sh. Test 31 fails ("refs IPFS directory file through readonly API succeeds").

@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label Dec 13, 2017
@Stebalien Stebalien removed the status/blocked Unable to be worked further until needs are met label Dec 14, 2017
@Stebalien
Copy link
Member Author

Possibly relevant error:

expecting success: 
    test_must_fail ipfs repo gc --stream-errors 2>&1 | tee repo_gc_out &&
    grep -q "Error: could not retrieve links for $LEAF1" repo_gc_out &&
    grep -q "Error: could not retrieve links for $LEAF2" repo_gc_out &&
    grep -q "Error: garbage collection aborted" repo_gc_out
  
Error: could not retrieve links for QmSijovevteoY63Uj1uC5b8pkpDU5Jgyk2dYBqz3sMJUPc: merkledag: not found
Error: could not retrieve links for QmTbPEyrA1JyGUHFvmtx1FNZVzdBreMv8Hc8jV9sBRWhNA: The block referred to by 'QmTbPEyrA1JyGUHFvmtx1FNZVzdBreMv8Hc8jV9sBRWhNA' was not a valid merkledag node
Error: json: cannot unmarshal number into Go value of type commands.GcResult

not ok 48 - 'ipfs repo gc --stream-errors' should abort and report each error separately

#	
#	    test_must_fail ipfs repo gc --stream-errors 2>&1 | tee repo_gc_out &&
#	    grep -q "Error: could not retrieve links for $LEAF1" repo_gc_out &&
#	    grep -q "Error: could not retrieve links for $LEAF2" repo_gc_out &&
#	    grep -q "Error: garbage collection aborted" repo_gc_out

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
Copy link
Member Author

Stebalien commented Dec 15, 2017

Possibly relevant error

I couldn't reproduce this error after running these tests for several (4?) hours on repeat. If I had to hazard a guess, I'd say that this was caused by a bug in the HTTP streaming implementation. I'm guessing it returned the final 0 instead of treating it as a length. (reported at #4494)


I believe this is ready to merge.

@whyrusleeping whyrusleeping merged commit 9db5471 into master Dec 15, 2017
@ghost ghost removed the status/in-progress In progress label Dec 15, 2017
@whyrusleeping
Copy link
Member

Wooo! thanks @Stebalien !

@whyrusleeping whyrusleeping deleted the gx/update-5osgb9 branch December 15, 2017 01:59
@djdv djdv mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sending SIGINT to ipfs repo verify incorrectly reports verify complete when daemon isn't running
2 participants