Ipns name resolution #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +60,7 @@ func ipfsCmd(c *commander.Command, args []string) error { | |||
|
|
|||
| func main() { | |||
| u.Debug = true | |||
| runtime.GOMAXPROCS(2) | |||
There was a problem hiding this comment.
curious why limiting concurrency?
There was a problem hiding this comment.
i beleive it actually defaults to one, i was bumping it to two just for my own sanity. (let me know if im wrong)
There was a problem hiding this comment.
num := runtime.NumCPU()
runtime.GOMAXPROCS(num)
Re: GOMAXPROCS
This call will go away when the scheduler improves.
There was a problem hiding this comment.
Yeah, and setting GOMAXPROCS to your number of CPU's is rarely a good idea (if you dont beleive me, go on #go-nuts and ask, lol). We should first determine a way to measure performance, and see how it changes across different numbers of procs.
whyrusleeping
added a commit
that referenced
this pull request
Sep 15, 2014
|
|
||
| var ErrCouldntResolve = errors.New("could not resolve name.") | ||
|
|
||
| type MasterResolver struct { |
There was a problem hiding this comment.
may want to make this struct private to prevent it from being instantiated without its handlers being initialized
whyrusleeping
force-pushed
the
master
branch
from
609a71b
to
5fafaa4
Compare
|
@whyrusleeping want to rebase on top of new master and then merge it in? What else is left? |
|
At this point it works. (as far as individual name resolution goes) I still need to test it in the grande scheme of things (i.e. requesting /ipns/jero.my or /ipns/base58hash) |
whyrusleeping
added a commit
that referenced
this pull request
Sep 22, 2014
|
@whyrusleeping I'm going to:
|
|
Btw: i noticed that you're merging sometimes when we're both working on same branch. pro-tip: rebase pull. # rebase pull
git pull --rebase
# setup branch to always rebase
git config branch.master.rebase true
# setup all future branches to rebase
git config branch.autosetuprebase always
git config --global branch.autosetuprebase alwayshttp://gitready.com/advanced/2009/02/11/pull-with-rebase.html |
- cleaned up cmd help - ipfs name publish [<name>] <ref> - ipfs name resolve [<name>] - publish validates <ref> - both validate n args
Conflicts: cmd/ipfs/ipfs.go
|
|
|
|
|
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
make it easier to detect an uninitialized repo
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
make it easier to detect an uninitialized repo
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
make it easier to detect an uninitialized repo
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
make it easier to detect an uninitialized repo
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Apr 7, 2022
fix: slightly reduce memory usage when walking large directory trees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is not yet complete, but before i move forward, the name resolution code (in namesys) needs some critiquing. There are also a decent number of bugfixes in this branch that i ran into while trying to get the code to a point where i could test ipns.