Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go test on Windows #4632

Merged
merged 5 commits into from
Feb 4, 2018
Merged

Fix go test on Windows #4632

merged 5 commits into from
Feb 4, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jan 31, 2018

This fixes windows issues @victorbjelkholm had in #4430 (comment).

There is still one test failing:

--- FAIL: TestReprovide (0.05s)
        reprovide_test.go:51: Should have gotten a provider

This will need a fix in https://github.com/libp2p/go-libp2p-peer/blob/master/test/utils.go#L23. The problem here is that time.Now().UnixNano() resolution on windows is really poor (multiple ms)

@magik6k magik6k added kind/test Testing work topic/windows Windows specific labels Jan 31, 2018
@ghost ghost assigned magik6k Jan 31, 2018
@ghost ghost added the status/in-progress In progress label Jan 31, 2018
@magik6k magik6k mentioned this pull request Jan 31, 2018
Closed
Stebalien
Stebalien approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorb
Copy link
Member

victorb commented Feb 2, 2018

libp2p/go-libp2p-peer#28 has been merged and this seems to be ready to be merged.

@magik6k
Copy link
Member Author

magik6k commented Feb 2, 2018 •
edited
Loading

It has been merged, though it needs to be propagated. #4637 updates go-libp2p-peer, though one version before thin fix

@whyrusleeping
Copy link
Member

@magik6k this will need a rebase. Let me know when its good to go

@magik6k
fix test data on windows
6d28f8f 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
disable some tests on windows
d399cdf 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
fix pin test on windows
f1c4df8 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
disable perm check in serialize_test.go/TestConfig on windows
2b6641d 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
"fix" routing/mock tests on windows
dcfcfc5 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@whyrusleeping whyrusleeping merged commit 864c960 into master Feb 4, 2018
@whyrusleeping whyrusleeping deleted the fix/windows-tests branch February 4, 2018 02:16
@ghost ghost removed the status/in-progress In progress label Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

@magik6k magik6k

Labels
kind/test Testing work topic/windows Windows specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @victorb @whyrusleeping @Stebalien