-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document ipns pubsub #4903
Merged
Merged
document ipns pubsub #4903
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -365,3 +365,41 @@ ipfs config --json Experimental.ShardingEnabled true | |
|
||
- [ ] Make sure that objects that don't have to be sharded aren't | ||
- [ ] Generalize sharding and define a new layer between IPLD and IPFS | ||
|
||
--- | ||
|
||
## IPNS pubsub | ||
|
||
### In Version | ||
|
||
0.4.14 | ||
|
||
### State | ||
|
||
Experimental, default-disabled. | ||
|
||
Utilizes pubsub for publishing ipns records in real time. | ||
|
||
When it is enabled: | ||
- IPNS publishers push records to a name-specific pubsub topic, | ||
in addition to publishing to the DHT. | ||
- IPNS resolvers subscribe to the name-specific topic on first | ||
resoltion and receive subsequently published records through pubsub | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo on “resolution” There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed, thanks. |
||
in real time. This makes subsequent resolutions instant, as they | ||
are resolved through the local cache. Note that the initial | ||
resolution still goes through the DHT, as there is no message | ||
history in pubsub. | ||
|
||
Both the publisher and the resolver nodes need to have the feature enabled for it | ||
to work effectively. | ||
|
||
### How to enable | ||
|
||
run your daemon with the `--enable-namesys-pubsub` flag; enables pubsub. | ||
|
||
### Road to being a real feature | ||
|
||
- [ ] Needs more people to use and report on how well it works | ||
- [ ] Add a mechanism for last record distribution on subscription, | ||
so that we don't have to hit the DHT for the initial resolution. | ||
Alternatively, we could republish the last record periodically. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say slightly more about how it works/what it does? e.g:
I’m not even totally sure my understanding there is correct, so please fix if it’s not!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, the important part is: what should the user expect and why would they want to try this feature out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Exactly that ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fine, I'll add another
sentenceparagraph :)