[WIP][PoC] analyze MFS Close()
#5173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would tend to think that this is handled through `closeChild()` and `Directory`'s `Flush()` (if responsibly called). License: MIT Signed-off-by: Lucas Molas <schomatis@gmail.com>
schomatis
added
status/in-progress
And the functions of its only consumer, IPNS. License: MIT Signed-off-by: Lucas Molas <schomatis@gmail.com>
|
This is strange, the second commit is actually passing the online tests, but in my machine |
|
Yes, they are. |
schomatis
changed the title
Close() from Finalize()Close()
|
@schomatis is it safe to close this PR? It sounds like maybe it was for CI testing? |
|
Sure, thanks for the remainder! |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge.
The first commit passes the tests (Jenkins doesn't count), the second one doesn't, which make sense: IPNS doesn't use the
closeChild()and related functions (I'm imagining), modifications are not signaled to MFS as theipfs filescommands do (MFS files are just being modified by the filesystem) so it does need an explicitClose()call.If this reasoning is correct we can eliminate the
Close()call from thecoreunixpackage (first commit) and document the function as being used only by IPNS, this will largely clarify its relationship withcloseChild().To do: address this in #5092.