Fixed ipns address resolution in fuse unix mount #5327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks correct. Could you add the signoff trailers? |
|
Added the License and Sign-Off trailers. |
Stebalien
approved these changes
Aug 11, 2018
Kubuxu
reviewed
Aug 14, 2018
fuse/ipns/ipns_unix.go
Outdated
| @@ -196,7 +196,8 @@ func (s *Root) Lookup(ctx context.Context, name string) (fs.Node, error) { | |||
| } | |||
|
|
|||
| // other links go through ipns resolution and are symlinked into the ipfs mountpoint | |||
| resolved, err := s.Ipfs.Namesys.Resolve(s.Ipfs.Context(), name) | |||
| ipns_name := "/ipns/" + name | |||
There was a problem hiding this comment.
I would prefer if there was no underscore in the name.
ghost
assigned
|
Dammit git! Sorry, for some reason git never seems to understand that when I push from a branch, I mean to push that branch (not some other branch because reasons). New PR: #5384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.