move VersionOption after GatewayOption to fix #5422

[swedneck]

No description provided.

[magik6k]

Thanks!

Can you try adding a test case for that? (probably around https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/gateway_test.go#L147-L177)

[swedneck]

I'm not sure what you want me to add, i've never worked with the ipfs code (or go) before..

[Stebalien]

I think this'll still miss, e.g., /api/v0/version. Is that correct? I think the correct order here is:

corehttp.MetricsCollectionOption("gateway"),
corehttp.IPNSHostnameOption(),
corehttp.GatewayOption(writable, "/ipfs", "/ipns"),
corehttp.VersionOption(),
corehttp.CheckVersionOption(),
corehttp.CommandsROOption(*cctx),

That is:

1. Collect metrics first.
2. Do any IPNS based redirects.
3. Handle /ipfs, /ipns next.
4. Handle /version.
5. Check client's declared a go-ipfs version (if specified). Put this right before the read only commands option as we don't care about the client version for anything except the read-only commands.
6. Forward to the read-only commands.

[Stebalien]

Testing will be a bit tricky so we can handle that.

[swedneck]

Should i change the order to that and push the commit here?

[Stebalien]

@swedneck Yes (when you get a chance).