Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test on 32bit os #5429

Merged
merged 2 commits into from
Mar 5, 2019
Merged

ci: test on 32bit os #5429

merged 2 commits into from
Mar 5, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Sep 6, 2018

To test for stuff like #5367

There is also one test fail in gateway test code:

core/corehttp/gateway_test.go:42:9: constant 18446744073709551615 overflows uint

@magik6k magik6k requested a review from Kubuxu as a code owner September 6, 2018 14:28
@ghost ghost assigned magik6k Sep 6, 2018
@ghost ghost added the status/in-progress In progress label Sep 6, 2018
@magik6k
Copy link
Member Author

magik6k commented Sep 6, 2018

Blocked on #5367 / propagating new badger

@magik6k magik6k added the status/blocked Unable to be worked further until needs are met label Sep 6, 2018
@magik6k magik6k mentioned this pull request Sep 18, 2018
Merged
@ghost ghost assigned Stebalien Jan 24, 2019
Stebalien
Stebalien reviewed Jan 24, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased as badger has been updated.

test/bin/Rules.mk
@@ -30,18 +30,18 @@ TGTS_GX_$(d) := hang-fds
TGTS_GX_$(d) := $(addprefix $(d)/,$(TGTS_GX_$(d)))

$(TGTS_GX_$(d)):
go build -i $(go-flags-with-tags) -o "$@" "$(call gx-path,$(notdir $@))"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember why we needed to remove this flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC when cross compiling, go would try to write objects to /usr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Yeah, that makes sense.

@Stebalien
Copy link
Member

Stebalien commented Jan 24, 2019 •
edited
Loading

Still blocked: #5367 (comment)

@magik6k @Stebalien
ci: test on 32bit os
d8a9222 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien
fix gateway_test on 32bit oses
23616af 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien removed the status/blocked Unable to be worked further until needs are met label Mar 5, 2019
Stebalien
Stebalien approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer use Jenkins but we might as well merge this before it bitrots.

@Stebalien Stebalien merged commit 1b45a98 into master Mar 5, 2019
@Stebalien Stebalien deleted the ci/32bit branch March 5, 2019 06:12
@ghost ghost removed the status/in-progress In progress label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @Stebalien