commands/object: use new cmds #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbool
changed the title
overbool
force-pushed
the
refactor/commands/object
branch
from
aeedabc
to
f70a8e3
Compare
|
@Stebalien CI checks have passed, could u help me review it? |
kevina
reviewed
Nov 1, 2018
| cmdkit "gx/ipfs/Qmde5VP1qUkyQXKCfmEUA7bP64V2HAptbJ7phuPp7jXWwg/go-ipfs-cmdkit" | ||
| ) | ||
|
|
||
| const ( | ||
| verboseOptionName = "verbose" |
There was a problem hiding this comment.
Is there a reason for this?
Nothing wrong with, but it's not very consistent as we don't use contacts for any of the other options in this file.
Personally, I would err on the side of not using the constant, but others may disagree.
There was a problem hiding this comment.
@kevina version is used in two places, so I use the constant.
There was a problem hiding this comment.
So is almost every other option, or am I missing something.
In any case it not that big of a deal.
There was a problem hiding this comment.
Most of the commands have actually been changed to use constants for these.
Stebalien
previously requested changes
Nov 2, 2018
| } | ||
|
|
||
| res.SetOutput(data) | ||
| return res.Emit(data) |
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
Stebalien
force-pushed
the
refactor/commands/object
branch
from
252e0d3
to
e1d1f68
Compare
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: #5664
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com