Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx: update go-ipfs-config #5798

Merged
merged 1 commit into from
Nov 27, 2018
Merged

gx: update go-ipfs-config #5798

merged 1 commit into from
Nov 27, 2018

Conversation

Stebalien
Copy link
Member

* AutoRelay options for #5785.
* Badger truncate-by-default option for #5275, #5625.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Nov 27, 2018
@ghost ghost added the status/in-progress In progress label Nov 27, 2018
@Stebalien
Copy link
Member Author

I don't believe merging this before the relevant PRs will cause any issues but please speak up if that's not the case. Unfortunately, due to the fact that this is in a separate repo, we kind of have a chicken-egg issue (and I'd rather not bundle all the changes together).

@kevina
Copy link
Contributor

kevina commented Nov 27, 2018

I never did like the fact that we decided to move go-ipfs-config into a separate repo for these reasons.

I don't see how this can cause a problem, but it appears Jenkins is falling for unrelated reasons.

@schomatis
Copy link
Contributor

So this means that we'll be including a truncate field now but we will be ignoring it, doing a quick test this doesn't seem to break anything, although it may give the erroneous impression to the user but that seems like a minor issue (assuming #5625 will be merged in the near future).

@Stebalien Stebalien merged commit d40c69f into master Nov 27, 2018
@ghost ghost removed the status/in-progress In progress label Nov 27, 2018
@Stebalien Stebalien deleted the gx/update-config branch November 27, 2018 17:56
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
gx: update go-ipfs-config

This commit was moved from ipfs/kubo@d40c69f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants