reduce verbosity of daemon start #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
This isn't an error and 99.999% of users won't care. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
|
I've kept the version information because it's pretty useful but we could try adding some space. |
magik6k
reviewed
Jan 8, 2019
There was a problem hiding this comment.
I'd also print additional \n after printVersion() - https://github.com/ipfs/go-ipfs/pull/5904/files#diff-54f2c4a5481de30b8ccb59ad5b6588b3L199, would make it even more readable:
Initializing daemon...
go-ipfs version: 0.4.19-dev-7a9b1716f
Repo version: 7
System version: amd64/linux
Golang version: go1.11.4
Error: no IPFS repo found in /tmp/xyz.
please run: 'ipfs init'
The `ipfs init` command prints out a ton of information which can make it hard to spot errors. Print a newline before these errors We could do this for every command but there are some tricky edge cases: 1. This would look funny if there's no other output. 2. It might mess break tools parsing the output (not expecting empty lines). License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
|
I've pushed a commit that adds a new line when exiting the daemon command with an error. That way, it doesn't matter where we run into an error, it'll always be clear. We could do this for all commands but always prepending a newline could look a bit funky. |
magik6k
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, avoid printing C-c message unless we actually start the daemon:
Now
ipfs daemonwith no repo prints:work towards: #5903