fix: show interactive output from install.sh #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying out the latest rc, i used the `./install.sh` It hung, with no output. I removed the 2> /dev/null and it turned out mv was waiting for user input to confirm the change of file permssions from 555 to 755. This PR removes piping the output from mv to /dev/null as it seems like the safest fix. An alternative would be to just add -f but i've err'd on the side of caution. If also tweaked the second condition basedo on the recommendations of shellcheck see: https://github.com/koalaman/shellcheck/wiki/SC2166 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Stebalien
approved these changes
Feb 26, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying out the latest rc, i used the
./install.shIt hung, with no output. I removed the 2> /dev/null and
it turned out mv was waiting for user input to confirm
the change of file permssions from 555 to 755.
override r-xr-xr-x oli/staff for /usr/local/bin/./ipfs? (y/n [n])This PR removes piping the output from mv to /dev/null
as it seems like the safest fix.
An alternative would be to just add -f but i've err'd
on the side of caution.
If also tweaked the second condition based on the
recommendations of shellcheck
see: https://github.com/koalaman/shellcheck/wiki/SC2166
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io