-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix level db panic #6186
Fix level db panic #6186
Conversation
@Stebalien I'm actually using this PR to troubleshoot the leveldb panics as I can't reproduce them locally. Are you saying #6185 should fix that? |
Ah, no. Sorry, different issue. In terms of the leveldb panics, I think we're closing the datastore while reading from it (or reading from it after closing it?). |
@Stebalien yeah, there are those panics and there's also the panic from the pinning test:
They could be related. The other panics (the |
29bf7bb
to
723bb8b
Compare
67653f6
to
126f613
Compare
@Stebalien we had something like your suggestion earlier, but ran into some issues that I didn't this time around. Changes are in. Let me know if you had something else in mind. |
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
Ok, one more blocker down. Thanks! |
This PR exists for me to trouble shoot some CI issues. Disregard.