-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stackdriver export #6217
Add Stackdriver export #6217
Conversation
Are there any discussions / issues linked to this? |
@magik6k What sort are you referring to? There's efforts in filecoin to do tracing, and libp2p to tracing and metrics via OpenCensus. |
@anacrolix – I believe @magik6k is referring to the attempt to introduce Stackdriver specifically. It's not clear to me the kind of feedback you are seeking, either. (It's obvious this approach will not be accepted as-is -- it's tied to your personal Google account for starters). |
I'd like to know if OC exporters could be supported, via environment flags, similar to as is done in this PR for Stackdriver. |
I'll update this PR to be more general, to reflect how I've done this in other projects. |
ce37190
to
dd7fdb2
Compare
Using env vars feels better. What is the difference in binary size with this patch applied? Can this be made into a plugin? |
|
As a plugin, I wonder if having upstream projects in libp2p directly reference opencensus tracing will defeat the purpose (the dependencies will be pulled in anyway). In particular, while there is no OC tracing in libp2p yet, I think there will be soon, and the cost will already be paid to add that there. It may be possible to avoid that cost, by tapping into OC's |
6MB is a lot, especially given that it isn't going to be used by 99.99% of users. Can we hide this behind a build tag, say |
It looks like a almost all of the weight comes from the stackdriver exporter, not opencensus. Putting the stackdriver code in a plugin should help quite a bit. |
Thanks @Stebalien, that seems like the best solution. |
(we'll reopen this when we pick this work back up) |
I'm using this to export traces to Stackdriver. I'd like some feedback. Perhaps the exporter Location and default sample rate can be taken from the environment, and the export only attempted if particular environment variables are set.