-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 0.4.20 #6223
release 0.4.20 #6223
Conversation
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
cc @ipfs/go-team |
to an _arbitrary_ peer as DNS is not secure (by default). Please do not rely on | ||
this except for testing or unless you know what you're doing. | ||
|
||
Finally, `ipfs swarm connect` now returns _all_ errors on failure. This should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a change to the HTTP API that I'll need to account for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is just a behavior tweak. Ideally, we'll improve the connection manager later so it won't be necessary.
|
||
#### Changed: `ipfs files flush` | ||
|
||
The `ipfs files flush` command now returns the CID of the flushed file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @achingbrain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we did this to improve the CoreAPI. IIRC, my end goal was to avoid exposing any CIDs to the user until they explicitly call Flush
so we can make the actual IPFS import part lazy.
|
||
The `ipfs swarm connect` command has a few new features: | ||
|
||
It now marks the newly created connection as "important". This should ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be looking at adding tagging support in js this quarter for connection management, so this is something we should be able to look at adding in q3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I noted above, this shouldn't really be necessary. However, we're still killing useful connections so this change makes the issue slightly less annoying.
CHANGELOG.md
Outdated
#### Relays | ||
|
||
After AutoRelay was introduced in go-ipfs 0.4.19, the number of peers connecting | ||
through relays ski-rocketed to over 120K concurrent peers. This highlighted some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sky, not ski!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emoji opportunity: 🎿-rocketed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️... too much skiing.
CHANGELOG.md
Outdated
rapidly forming new connections. This will actually help _all_ nodes but will | ||
especially help relays. | ||
|
||
If you've enabled relays in go-ipfs 0.4.19 and it hasn't burned down your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably : "if you've enabled relay hop".
CHANGELOG.md
Outdated
the docker container: | ||
|
||
```bash | ||
> docker run ipfs/go-ipfs config profile apply server # apply the server profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some users not familiar with Docker may just copy&paste commands and get surprised that container started by the second command does not include changes applied by the first one.
A safer example would be to use the same container in both, e.g:
$ docker run --name my-container ipfs/go-ipfs:v0.4.20 config profile apply server # apply the server profile
$ docker start my-container # start the daemon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone not familiar with docker, thanks...
CHANGELOG.md
Outdated
#### Relays | ||
|
||
After AutoRelay was introduced in go-ipfs 0.4.19, the number of peers connecting | ||
through relays ski-rocketed to over 120K concurrent peers. This highlighted some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emoji opportunity: 🎿-rocketed
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(per @lidel's CR) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
92abd6d
to
79fcdfe
Compare
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
79fcdfe
to
a2e2055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for my Bitswap work
Good enough for me. We can always edit the release notes after the fact and I want this out the door. |
forget to send out this record, even if it was offline when the content was | ||
initially added. NOTE: go-ipfs _does_ continuously _re_-send provider records in | ||
the background twice a day, it just might be a while before it gets around to | ||
sending one out any specific one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo (very minor): I think this should be something like "...before it gets around to sending any specific one"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(could you file a PR to fix this)
LGTM wrt Content Routing |
This has been running on the gateways for several days. There are still a few issues unresolved but it looks good enough to ship.
closes #6223