fix(identify) Handshake #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle subroutine errors * further specify the type of channel
added 5 commits
September 12, 2014 22:54
|
This looks good, can you verify that the root cause has been addressed? |
|
@whyrusleeping The root cause has not yet been addressed. Tests still failing occasionally (~1/15 runs). Handshake is due for a more substantial rewrite. We should certainly stay on top of the issue, but this issue is not a blocker. @jbenet has agreed to have a look at the Will assign the issue to jbenet. @whyrusleeping, @jbenet please sign-off on these minor fixes now. No harm in merging these in. |
|
Yeah, go ahead and merge them |
Closed
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Update go-cid, go-datastore
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…/multiformats/go-multiaddr-0.2.1 Bump github.com/multiformats/go-multiaddr from 0.2.0 to 0.2.1
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…dules/github.com/multiformats/go-multiaddr-0.2.1 Bump github.com/multiformats/go-multiaddr from 0.2.0 to 0.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs to squash:
HandshakefailureProgress:
This PR is to be merged once it is able to address:
#61 (comment)
@whyrusleeping feel free to push to this branch