Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix build when we don't have a full git tree #6626

Merged
merged 1 commit into from
Sep 4, 2019
Merged

build: fix build when we don't have a full git tree #6626

merged 1 commit into from
Sep 4, 2019

Conversation

Stebalien
Copy link
Member

When building with docker, we don't have a full git repo.

@Stebalien
build: fix build when we don't have a full git tree
aba6c3d 
When building with docker, we don't have a _full_ git repo.
@Stebalien Stebalien mentioned this pull request Sep 4, 2019
Closed
@Stebalien Stebalien requested review from gmasgras and removed request for hsanjuan September 4, 2019 20:41
gmasgras
gmasgras approved these changes Sep 4, 2019
View reviewed changes
Copy link

@gmasgras gmasgras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stebalien Stebalien merged commit 1bcea7c into master Sep 4, 2019
@Stebalien Stebalien deleted the fix/6622 branch September 4, 2019 22:01
This was referenced Jan 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmasgras gmasgras gmasgras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @gmasgras