feat(util:context) adds extended context interface #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 14, 2014 01:01
errors are piped to parent when parent instantiates a context with:
WithErrorLog
added 12 commits
September 14, 2014 03:50
exercise inheritance through error logging context
| // wrap() wraps |ctx| to extend its interface and turns |f| into a CancelFunc | ||
| func wrap(ctx goctx.Context, f goctx.CancelFunc) (*wrappedContext, CancelFunc) { | ||
| w := &wrappedContext{Context: ctx, errLogChan: make(chan error)} | ||
| return w, CancelFunc(f) |
There was a problem hiding this comment.
Im naive to the uses of contexts, but why do we return the cancelFunc?
There was a problem hiding this comment.
The cancelFunc can be used to manually cancel the context.
ctx, f := context.WithCancel(parent)
go operation(ctx)
// decide to cancel operation
f()
|
I think I can make this simpler. But it's lower priority than Helping to get the net stuff merged into master is my priority. |
whyrusleeping
force-pushed
the
master
branch
from
609a71b
to
5fafaa4
Compare
btc
pushed a commit
that referenced
this pull request
Sep 23, 2014
This commit... is a second attempt at: #68 partially addresses: #66 is the result of discussion at: https://gist.github.com/perfmode/f2951c1ed3a02c484d0b
|
see #108 |
btc
pushed a commit
that referenced
this pull request
Sep 23, 2014
This commit... is a second attempt at: #68 partially addresses: #66 is the result of discussion at: https://gist.github.com/perfmode/f2951c1ed3a02c484d0b
btc
pushed a commit
that referenced
this pull request
Sep 24, 2014
This commit... is a second attempt at: #68 partially addresses: #66 is the result of discussion at: https://gist.github.com/perfmode/f2951c1ed3a02c484d0b
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
chore: remove unnecessary dependency
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
chore: remove unnecessary dependency
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
chore: remove unnecessary dependency
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
chore: remove unnecessary dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new interface is a drop-in replacement for the go.net.context.
It adds an error logging method:
TODO: