Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): update deps #6832

Merged
merged 3 commits into from
Jan 29, 2020
Merged

chore(dep): update deps #6832

merged 3 commits into from
Jan 29, 2020

Conversation

Stebalien
Copy link
Member

Update all deps.

@Stebalien Stebalien requested a review from olizilla January 17, 2020 00:20
@Stebalien
Copy link
Member Author

@olizilla I assume we don't scrape ipfs log tail for metrics, right?

@Stebalien
Copy link
Member Author

I'm asking you for a review because I'm removing some event tracing.

Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we don't depend on ipfs log tail for any metrics. Will need a breaking change note in the release.

We've deprecated this system and have yet to move to a new system. We might as
well remove everything, switch to a new system, then deliberately trace the
entire system.
@Stebalien Stebalien merged commit 37e0a60 into master Jan 29, 2020
@Stebalien Stebalien deleted the chore/update-deps branch January 29, 2020 05:45
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
chore(dep): update deps

This commit was moved from ipfs/kubo@37e0a60
gammazero pushed a commit to ipfs/boxo that referenced this pull request Sep 29, 2023
chore(dep): update deps

This commit was moved from ipfs/kubo@37e0a60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants