fix(subdomain-gw): curl on localhost (Option B: User-Agent sniff) #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #6975 When request is sent to http://localhost:8080/ipfs/$cid we check User-Agent and disable subdomain redirect if it is a known cli tool that does not follow redirects by default. We also set Clear-Site-Data header on 'localhost' responses to ensure Origin sandbox can't be abused. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Closed
lidel
changed the title
|
Closing because we've selected option A (#6984). Please do not delete this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When request to
localhost/ipfs/*is processed:Clear-Site-DataheaderUser-Agentis matching known cli tool^(curl|wget)/i