Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tls by default #7055

Merged
merged 1 commit into from
Mar 30, 2020
Merged

feat: tls by default #7055

merged 1 commit into from
Mar 30, 2020

Conversation

Stebalien
Copy link
Member

Switches to TLS as the default security transports.

@Stebalien Stebalien mentioned this pull request Mar 30, 2020
Closed
21 tasks
willscott
willscott approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only question would be if it's worth having a config option for preferring secio, but since fallback to secio should still work, that seems like something that can be deferred until someone expresses a need for it.

@Stebalien
Copy link
Member Author

only question would be if it's worth having a config option for preferring secio, but since fallback to secio should still work, that seems like something that can be deferred until someone expresses a need for it.

If it's an issue in practice and TLS is a problem, we'll cut a patch release.

@Stebalien
Copy link
Member Author

I'd like to just keep the config option but we have no way of changing defaults (see #8776).

@Stebalien
feat: tls by default
f28b8fc 
Switches to TLS as the default security transports.
@Stebalien
Copy link
Member Author

(updated docs)

@Stebalien Stebalien merged commit 643acab into master Mar 30, 2020
@hacdias hacdias deleted the feat/tls-by-default branch May 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @willscott