feat: nice errors when failing to load plugins #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Jun 9, 2020
| } | ||
|
|
||
| func loadPlugin(fi string) ([]iplugin.Plugin, error) { | ||
| func unixLoadPlugin(fi string) ([]iplugin.Plugin, error) { |
There was a problem hiding this comment.
Before, we wouldn't try loading plugins on platforms that didn't support plugins.
Now, we try loading plugins everywhere, but return an error if we find a plugin that we can't load (either because the platform is unsupported, or because something is wrong with the plugin).
|
bump @dirkmc |
aschmahmann
approved these changes
Aug 9, 2020
Stebalien
force-pushed
the
fix/plugin-load-error
branch
from
5239bd5
to
8f852f9
Compare
|
@aschmahmann it was just waiting on a review. |
aschmahmann
reviewed
Aug 9, 2020
partially fixes #7305
aschmahmann
force-pushed
the
fix/plugin-load-error
branch
from
811f138
to
c07b6fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #7305
The other half is to actually build with CGO support by default.