Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ipfs add with CIDv1 as default #8185

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 11, 2021

This PR is only for demonstration purposes, to identify all tests that require refactor and eventually close #4143 and ipfs/specs#247

Motivation

Main use case for CIDv1 is ipfs:// URI and subdomain gateways. In both cases we want case-insensitive base32 to avoid issues like ipfs/ipfs-companion#1006.

MVP: default unixfsv1 to CIDv1

Virtually all DAGs used in mentioned contexts are unixfsv1, so we can effectively solve most of issues by ensuring unixfsv1 imports produce CIDv1:

Alternative is to switch the defaults in github.com/ipfs/go-ipfs-files

Identified tests to fix

  • ? tests failed out of ? in interop
  • go-ipfs-api: ?
  • sharness (hard to count, it timeouts because CIDv1 can't be found due to apis producing v0) - migration tool in feat(test): migrate CIDv0-v1 tool #8898

This is wip, purpose is to identify all tests that require refactor
@lidel lidel changed the title feat: unixfs imports produce cidv1 test: ipfs add with CIDv1 as default Apr 7, 2022
@schomatis schomatis self-assigned this Apr 14, 2022
@schomatis
Copy link
Contributor

Similar to #8886, leaving sharness CID translation for last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make base32 CIDv1 the default for go-ipfs
2 participants