Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmds): extend block size check for dag|block put #8751

Merged
merged 5 commits into from
Mar 11, 2022
Merged

feat(cmds): extend block size check for dag|block put #8751

merged 5 commits into from
Mar 11, 2022

Conversation

schomatis
Copy link
Contributor

Had to create a new sub-package to share information between root commands package and child objectcmd package to avoid import cycles.

Closes #8696.

@schomatis schomatis requested a review from lidel February 25, 2022 14:01
@schomatis schomatis self-assigned this Feb 25, 2022
@BigLep BigLep added this to the Best Effort Track milestone Mar 3, 2022
@lidel lidel assigned lidel and unassigned schomatis Mar 11, 2022
lidel
lidel approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @schomatis!

  • added the same check to ipfs dag import + test
  • replaced 1MB with 1MiB as suggested by @aschmahmann
  • CI is green → merging

@lidel lidel merged commit 04e7e95 into master Mar 11, 2022
@lidel lidel deleted the schomatis/cli/ipfs-dag-block-size-error branch March 11, 2022 22:23
@schomatis
Copy link
Contributor Author

Thanks for moving so fast on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann left review comments

@lidel lidel lidel approved these changes

Assignees

@lidel lidel

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
go-ipfs 0.13
Development

Successfully merging this pull request may close these issues.

fix: dag|block put: do not allow blocks over BS limit
4 participants
@schomatis @lidel @aschmahmann @BigLep