Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update kubo-as-a-library example #9127

Merged
merged 1 commit into from
Jul 25, 2022
Merged

chore: update kubo-as-a-library example #9127

merged 1 commit into from
Jul 25, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 19, 2022 •
edited
Loading

Part of #8959

This PR updates library example to use "kubo" name 🧊

Added symlink docs/examples/go-ipfs-as-a-library so old docs and examples still work (and web user knows where to go next).

Closes #8917

@lidel lidel requested a review from Jorropo July 19, 2022 21:10
@lidel lidel self-assigned this Jul 19, 2022
@lidel lidel force-pushed the chore/update-kubo-as-a-library branch from 1cb8209 to fd83c91 Compare July 19, 2022 21:15
@lidel lidel requested a review from ajnavarro July 19, 2022 21:16
@lidel lidel force-pushed the chore/update-kubo-as-a-library branch from fd83c91 to a49a934 Compare July 19, 2022 21:25
@lidel lidel marked this pull request as ready for review July 19, 2022 22:29
@lidel lidel force-pushed the chore/update-kubo-as-a-library branch from a49a934 to 10cf839 Compare July 25, 2022 00:31
ajnavarro
ajnavarro reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@ajnavarro ajnavarro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we create a Go example to test that everything works on build time? To avoid problems like this one in the future.

@ajnavarro ajnavarro self-requested a review July 25, 2022 14:02
@lidel
Copy link
Member Author

lidel commented Jul 25, 2022 •
edited
Loading

@ajnavarro we already go test this example on CI (here),
this PR updates that test to use the new name. Do you mean something beyond that?

(merging this, we can improve in follow-up PR)

@lidel lidel merged commit 2f08eb4 into master Jul 25, 2022
@lidel lidel deleted the chore/update-kubo-as-a-library branch July 25, 2022 14:48
@ajnavarro
Copy link
Member

Yeah, I was thinking of using Go testable examples func ExampleKuboAsLibrary() {. This will avoid updating Kubo dependencies in the future, and if we break backward compatibility we will notice it when executing Kubo tests.

@BigLep BigLep mentioned this pull request Jul 26, 2022
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@Jorropo Jorropo Awaiting requested review from Jorropo

Assignees

@lidel lidel

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch go-ipfs-as-a-library to go-ipfs/config
2 participants
@lidel @ajnavarro