fix: honour --ttl flag in 'ipfs name publish' #9471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2022
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
from
713cc21
to
6d118e2
Compare
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
3 times, most recently
from
1697988
to
6671993
Compare
hacdias
changed the title
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
2 times, most recently
from
f0b9e90
to
1db6669
Compare
hacdias
commented
Dec 13, 2022
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
3 times, most recently
from
e32eb1b
to
96414b9
Compare
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
3 times, most recently
from
0df0d8f
to
63fd9b2
Compare
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
from
63fd9b2
to
982ff1e
Compare
lidel
reviewed
Jan 24, 2023
lidel
requested changes
Jan 25, 2023
There was a problem hiding this comment.
@hacdias Thank you for fixing this and indulging my idea to implement ipfs name inspect :)
I've bubbled up all changes, and switched this PR to go-namesys release, but there are some UX issues around ipfs name inspect that should be easy to fix, and better to do it now as we may not have better oportunity later.
See comments below, I'll do another pass on this when I'm back on Thursday 🙏
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
2 times, most recently
from
204ea6f
to
8b48923
Compare
hacdias
force-pushed
the
fix/use-ttl-on-ipns-entry
branch
from
8b48923
to
1e4c6a0
Compare
lidel
approved these changes
Jan 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the option
--ttlinipfs name publishwas never being used, and all IPNS records were being published with aTTLof 0. This was happening because the TTL was being passed to a different package through context, but because types are different (and context is not designed for that), the value would never get tonamesys.I updated the required packages to add the options and consolidate
PublishandPublishWithEOLinto a single function with optional options. See linked PRs.