Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add response body limiter to routing HTTP client #9478

Merged
merged 1 commit into from
Dec 8, 2022
Merged

feat: add response body limiter to routing HTTP client #9478

merged 1 commit into from
Dec 8, 2022

Conversation

guseggert
Copy link
Contributor

No description provided.

@guseggert guseggert self-assigned this Dec 7, 2022
@guseggert
Copy link
Contributor Author

part of ipfs/go-delegated-routing#63

@guseggert
Copy link
Contributor Author

this is a followup as mentioned here: #9453 (comment)

@guseggert guseggert marked this pull request as ready for review December 7, 2022 22:48
@guseggert guseggert mentioned this pull request Dec 7, 2022
Closed
BigLep
BigLep reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously feel free to wait on others, but intuitively makes sense.

I see the message that this isn't getting test covered. I assume that's not easy to add?

@guseggert guseggert merged commit bf61e63 into master Dec 8, 2022
@guseggert guseggert deleted the feat/routing-http-response-limiter branch December 8, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigLep BigLep BigLep left review comments

@ajnavarro ajnavarro ajnavarro approved these changes

Assignees

@guseggert guseggert

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guseggert @BigLep @ajnavarro