feat(gateway): error handling improvements (500, 502, 504) #9660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lidel
requested changes
Feb 23, 2023
hacdias
force-pushed
the
go-libipfs-errors
branch
4 times, most recently
from
4922af6
to
a597d5e
Compare
hacdias
force-pushed
the
go-libipfs-errors
branch
from
a597d5e
to
37fc918
Compare
lidel
force-pushed
the
go-libipfs-errors
branch
from
37fc918
to
0538cce
Compare
lidel
changed the title
4 tasks
hacdias
force-pushed
the
go-libipfs-errors
branch
from
e841c4b
to
fda8adf
Compare
hacdias
changed the title
hacdias
changed the title
2 tasks
|
@lidel I reused this PR because the previous PR in go-libipfs was already making the tests fail here. |
lidel
changed the title
lidel
approved these changes
Feb 28, 2023
| @@ -11,7 +11,7 @@ import ( | |||
| cidutil "github.com/ipfs/go-cidutil" | |||
| cmds "github.com/ipfs/go-ipfs-cmds" | |||
| bitswap "github.com/ipfs/go-libipfs/bitswap" | |||
| decision "github.com/ipfs/go-libipfs/bitswap/decision" | |||
| "github.com/ipfs/go-libipfs/bitswap/server" | |||
There was a problem hiding this comment.
💭 because of monorepo, we have to touch unrelated bitswap files in a PR about gateway HTTP codes :|
this one is cosmetic, but i feel things like this will get even more nasty as the time goes by, and we change more things in go-libipfs, and we will end up blocking each other.
cc @ipfs/kubo-maintainers for visibility / ideas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/boxo#182.
Requires: