bandwidth metering on streams #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
added
status/in-progress
whyrusleeping
force-pushed
the
feat/bw-meter
branch
2 times, most recently
from
3689d9a
to
f0031af
Compare
|
|
||
| var StatsCmd = &cmds.Command{ | ||
| Helptext: cmds.HelpText{ | ||
| Tagline: "Query IPFS daemon statistics", |
There was a problem hiding this comment.
maybe just Query IPFS daemon statistics -- we could have other stats there later, like number of objects stored on the repo, etc.
|
@whyrusleeping done with CR.
|
|
Fails race. ideally would drop down goroutine number back down. otherwise, need to lower numbers in
|
whyrusleeping
force-pushed
the
feat/bw-meter
branch
from
feb204d
to
2ac344b
Compare
whyrusleeping
force-pushed
the
feat/bw-meter
branch
from
2ac344b
to
f8b64c9
Compare
whyrusleeping
force-pushed
the
feat/bw-meter
branch
3 times, most recently
from
7f25f57
to
2c8cb9f
Compare
humanize bandwidth output instrument conn.Conn for bandwidth metrics add poll command for continuous bandwidth reporting move bandwidth tracking onto multiaddr net connections another mild refactor of recording locations address concerns from PR lower mock nodes in race test due to increased goroutines per connection
|
LGTM RFM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in bandwidth tracking per peer, per protocol, and overall. Also have a basic CLI command to access this data.
Query IPFS daemon statisticsbw --pollseems more natural.--period=<duration>flag in bw-pollndjsonin cmds commands lib should use ndjson #982SetConnWrapperon listener