feat: cmd/ipfs: Make it possible to depend on cmd/ipfs #9782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a much better way to inject plugins than the standard practice of modifying the preloads and rebuilding kubo bin. What are the drawbacks to this? |
|
@guseggert : maybe this is something you and @magik6k can discuss in person at IPFS Thing 2023? |
3 tasks
|
2023-05-18 maintainer conversation: all agreed this should get done for the next release. We haven't assigned an owner yet. A doc update should be made to https://github.com/ipfs/kubo/blob/master/docs/customizing.md as well. |
|
fyi the other branch - https://github.com/ipfs/kubo/compare/magiks-ribs-hacks - is now up to date with master. May make sense to swap this PR to that one |
Closed
|
Replaced by #10219. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there are two ways to run kubo with plugins, one on non-linux systems:
This PR adds a third way - by depending on
cmd/ipfs/kuboit's now possible to depend on this repo to create kubo-derived nodes with user-specified plugins.I needed this for RIBS, which is a highly-advanced blockstore, that couldn't justifiably "just be integrated" into upstream kubo.
mainusing this functionality: https://github.com/lotus-web3/ribs/blob/a8d8aff2953416bc267debd0ee05f591cca582d9/integrations/kuri/cmd/kuri/main.go#L16-L20Review probably easiest commit-by-commit.