feat: Gateway.DeserializedResponses config flag #9789
Conversation
hacdias
force-pushed
the
boxo/issue/225
branch
4 times, most recently
from
775bace
to
3de34fd
Compare
There was a problem hiding this comment.
Could tweak the name/meaning in Kubo, and add OnlyTrustless to the config?
It is a pretty important feature: people who want to run public gateway but don't want to be responsible for phising etc could easily remove the risk by enabling this.
This way, we don't need to deal with migrations / changing default behavior in Kubo (OnlyTrustless being false by default), but allow people to opt-in if they want.
hacdias
force-pushed
the
boxo/issue/225
branch
2 times, most recently
from
e3f6bf5
to
2613244
Compare
hacdias
changed the title
|
@Jorropo I added a very simple test. Don't forget that most of this is tested in Boxo. |
hacdias
force-pushed
the
boxo/issue/225
branch
3 times, most recently
from
775c593
to
45e72a0
Compare
We still want to check that the 2 lines of code plumbing the config to the boxo field are correct. 🙂 |
hacdias
changed the title
hacdias
force-pushed
the
boxo/issue/225
branch
2 times, most recently
from
3b51534
to
d461b58
Compare
There was a problem hiding this comment.
TrustedMode → DeserializedResponses
See ipfs/boxo#252 (review) for details
hacdias
changed the title
lidel
force-pushed
the
boxo/issue/225
branch
2 times, most recently
from
bd3ada1
to
a446062
Compare
There was a problem hiding this comment.
I've switched this PR to the latest version from ipfs/boxo#252 (review).
Good overall, but we need better UX and regression tests for all config variants.
I know this is extra work, would not ask normally for this level of paranoia, but misconfiguration of this flag could expose potential Trustless Gateway operators to risks that come with hosting deserialized data – details below.
lidel
changed the title
Add CAR and Accept header variants as regression tests, just in case things will break during yet another refactor (;
Pair PR of ipfs/boxo#252.
I simply update Kubo to use the new configuration structure and I keep all the defaults of Kubo, that is, everything is a trusted gateway unless
DeserializedResponsesis set tofalsein the configuration. Also added a simple test to check ifDeserializedResponsesis honoured. Further tests can be found in Boxo.Steps: