cache public keys and use better method for fetching #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return "", err | ||
| } | ||
|
|
||
| pubkey = pk |
There was a problem hiding this comment.
this is a pretty big function-- maybe abstract this piece (grabbing the key from routing) into a
func (r *routingResolver) getPublicKey(...) {}There was a problem hiding this comment.
Maybe even this could go in routing/routing.go as:
func GetPublicKey(r Routing, ...) {}
|
Couple comments above, otherwise lgtm |
whyrusleeping
force-pushed
the
feat/pubkey-cache
branch
2 times, most recently
from
69c7122
to
bb1b0d5
Compare
whyrusleeping
added a commit
that referenced
this pull request
Apr 1, 2015
cache public keys and use better method for fetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a new interface for optimized public key fetching that the DHT implements, otherwise fall back to a standard routing search.