Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Thunderdome docs for releases #9872

Merged
merged 1 commit into from
May 15, 2023
Merged

docs: add Thunderdome docs for releases #9872

merged 1 commit into from
May 15, 2023

Conversation

guseggert
Copy link
Contributor

@guseggert guseggert commented May 10, 2023

The Thunderdome testing will probably need additional documentation as we refine the process, and it's complicated enough that putting it inline in the release checklist is a bit much, so I've split it into its own file.

@guseggert guseggert force-pushed the docs/thunderdome branch 2 times, most recently from d0d981c to 1e9756a Compare May 10, 2023 16:44
@guseggert guseggert marked this pull request as ready for review May 10, 2023 16:44
@guseggert guseggert requested a review from a team as a code owner May 10, 2023 16:44
@guseggert guseggert self-assigned this May 10, 2023
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing Gus. Generally seems good. I think we're missing a step on how we collect and share the results.

I think keeping an experiment log like @iand did in https://www.notion.so/pl-strflt/ce2d1bd56f3541028d960d3711465659 makes sense. I am game for us putting the results there, but the expectation should be that as part of the release process we're updating the release issue with a link to the experiment where someone can see the grafana dashboard and our analysis (and any accompanying slack threads).

docs/releases_thunderdome.md Show resolved Hide resolved
@guseggert
Copy link
Contributor Author

the expectation should be that as part of the release process we're updating the release issue with a link to the experiment where someone can see the grafana dashboard and our analysis (and any accompanying slack threads).

This makes sense, just know that only PL folks can see the experiment dashboards (hosted Grafana dashboards can't be public).

@iand
Copy link
Contributor

iand commented May 11, 2023

We could host a prometheus+grafana in the thunderdome account just for collecting results and showing them publicly

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @guseggert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants