Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): human error pages, dag-cbor/dag-json preview #9904

Merged
merged 5 commits into from
May 31, 2023
Merged

feat(gateway): human error pages, dag-cbor/dag-json preview #9904

merged 5 commits into from
May 31, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 30, 2023 •
edited
Loading

@hacdias hacdias self-assigned this May 30, 2023
This was referenced May 30, 2023
Merged
Merged
@hacdias hacdias force-pushed the boxo/issues-262-307 branch from 9c8a245 to 1869a17 Compare May 30, 2023 12:22
@hacdias hacdias marked this pull request as ready for review May 30, 2023 12:32
@hacdias hacdias requested a review from a team as a code owner May 30, 2023 12:32
@hacdias hacdias changed the title feat(gateway): improved error pages, dag visualization feat(gateway): human error pages, dag-cbor/dag-json preview May 30, 2023
@hacdias hacdias requested a review from lidel May 30, 2023 12:32
@hacdias hacdias force-pushed the boxo/issues-262-307 branch 3 times, most recently from f6ef6a5 to 7c3d79e Compare May 31, 2023 14:02
@hacdias hacdias force-pushed the boxo/issues-262-307 branch from 0dcb0ed to 2829be5 Compare May 31, 2023 15:26
lidel
lidel approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias, this is a significant quality of life improvement for gateway users, and allows us to improve it even further in follow up PRs.

Merging to ensure this is included in Kubo 0.21.0-rc1 (#9814), and we can get feedback from stakeholders like @anjor.

Jorropo
Jorropo previously requested changes May 31, 2023
View reviewed changes
docs/changelogs/v0.21.md Outdated Show resolved Hide resolved
lidel and others added 2 commits June 1, 2023 01:34
@lidel lidel dismissed Jorropo’s stale review May 31, 2023 23:35

merged fix

@lidel lidel enabled auto-merge (squash) May 31, 2023 23:36
@lidel lidel merged commit dfd2448 into master May 31, 2023
@lidel lidel deleted the boxo/issues-262-307 branch May 31, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@Jorropo Jorropo Jorropo approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @lidel @Jorropo