Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds/dag/import: pin roots by default #9966

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 15, 2023

This is a partial revert of b685355, I don't want to silently break existing users.

Closes #9765 with compromise agreed in #9765 (comment)

This is a partial revert of b685355, I don't want to silently break existing users.
@Jorropo Jorropo requested review from lidel and a team as code owners June 15, 2023 14:32
@lidel lidel merged commit 82fd9ec into master Jun 15, 2023
@lidel lidel deleted the pin-roots-when-importing-car branch June 15, 2023 14:42
hacdias pushed a commit that referenced this pull request Jun 20, 2023
This is a partial revert of b685355.
Closes #9765 with compromise agreed in #9765 (comment)
hacdias pushed a commit that referenced this pull request Jun 20, 2023
This is a partial revert of b685355.
Closes #9765 with compromise agreed in #9765 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAR import should not pin roots by default (ipfs dag import --pin-roots=false)
3 participants