Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker repository initialization race condition #9992

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: docker repository initialization race condition #9992

merged 1 commit into from
Jun 27, 2023

Commits on Jun 26, 2023

  1. fix: docker repository initialization race condition 

    When running the health check command without passing the `--api` command line flag and if the Kubo daemon is not active, executing `ipfs dag stat` will initialize the repository. It is common for the health check command to be run with root privileges. As a result, the repository will be owned by the root user. Then, if the Kubo daemon process attempts to access the repository later on, it will encounter a permission denied error because it runs as a non-privileged user by default.

Hence, this modification simply provides the `--api` flag to the `ipfs dag stat` command. Given that we are operating within the limited confines of a docker container, we can make a few assumptions. I can't come up with a scenario where one would desire to assign a different port to the internal API rather than using the default 5001. Therefore, I have hard-coded the value accordingly.
    @dennis-tra
    dennis-tra committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8447d38 View commit details
    Browse the repository at this point in the history