Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust cid filter limits #62

Merged
merged 2 commits into from
Sep 18, 2020
Merged

fix: adjust cid filter limits #62

merged 2 commits into from
Sep 18, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 14, 2020 •
edited
Loading

This PR sets limit of 10 CIDs passed via cid filter to the GET /pins endpoint as suggested in #53

Closes #53 cc @obo20 @jacobheun

@lidel lidel requested review from jacobheun and a team September 14, 2020 10:25
@lidel lidel mentioned this pull request Sep 14, 2020
Closed
andrew added a commit to ipfs-shipyard/rb-pinning-service-api that referenced this pull request Sep 14, 2020
@andrew
Limit lookup by cid to max 10
e364d59 
ipfs/pinning-services-api-spec#62
andrew
andrew approved these changes Sep 14, 2020
View reviewed changes
Copy link

@andrew andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lidel lidel merged commit 3a07ea9 into master Sep 18, 2020
@lidel lidel deleted the fix/adjust-for-url-limits branch September 18, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@andrew andrew andrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjusting limits to match real-life URL length
3 participants
@lidel @andrew @jacobheun