Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli option to not encode/decode default values #48

Closed
wants to merge 1 commit into from
Closed

feat: cli option to not encode/decode default values #48

wants to merge 1 commit into from

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented Jul 8, 2022

Resolves #43

@D4nte

This comment was marked as outdated.

Sign in to view
@D4nte D4nte force-pushed the feat/expect-no-default-on-wire branch from 03ff2ed to eca5c46 Compare July 8, 2022 07:14
@D4nte D4nte force-pushed the feat/expect-no-default-on-wire branch from eca5c46 to 9845442 Compare July 28, 2022 21:39
@D4nte D4nte marked this pull request as ready for review July 28, 2022 21:39
@D4nte
Copy link
Contributor Author

D4nte commented Jul 28, 2022

@achingbrain this is now rebased and ready to go. lmk your thoughts.

@D4nte D4nte force-pushed the feat/expect-no-default-on-wire branch 2 times, most recently from e02d641 to c9ffd99 Compare July 29, 2022 02:02
@D4nte D4nte force-pushed the feat/expect-no-default-on-wire branch from c9ffd99 to e5294f8 Compare August 1, 2022 05:16
@fryorcraken fryorcraken mentioned this pull request Aug 8, 2022
Merged
@fryorcraken fryorcraken mentioned this pull request Aug 17, 2022
Closed
6 tasks
@fryorcraken fryorcraken mentioned this pull request Aug 25, 2022
Closed
2 tasks
@BigLep
Copy link

BigLep commented Sep 2, 2022

2022-09-02 triage note: posted notes and next steps in the issue: #43

@fryorcraken fryorcraken mentioned this pull request Sep 5, 2022
Closed
@lidel lidel added the need/maintainer-input Needs input from the current maintainer(s) label Sep 9, 2022
@fryorcraken
Copy link

fryorcraken commented Sep 14, 2022 •
edited
Loading

This should help : https://buf.build/blog/protobuf-language-specification

https://www.protobuf.com/docs/language-spec#field-presence-and-default-values

@BigLep
Copy link

BigLep commented Oct 7, 2022

2022-10-07 triage note: @achingbrain will open a followup PR to address #43

@BigLep BigLep removed the need/maintainer-input Needs input from the current maintainer(s) label Oct 7, 2022
@achingbrain
Copy link
Member

Fixed by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling of default values do not conform with proto3 language guide
5 participants
@D4nte @BigLep @fryorcraken @achingbrain @lidel