Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't lastpubver just be tied to gateways.json? #41

Closed
jamiew opened this issue Mar 2, 2019 · 2 comments
Closed

Shouldn't lastpubver just be tied to gateways.json? #41

jamiew opened this issue Mar 2, 2019 · 2 comments
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@jamiew
Copy link
Contributor

jamiew commented Mar 2, 2019

Right now it's wrapping index.html, app.json and gateways.json

The ipfg tool seems to be using that hash to cache version of gateway.json; is that how it's intended to be used? Hash of the latest list of gateways basically? (that makes sense to me)

Could also wire this up to that new GitHub app for automatically publishing

@jamiew jamiew added the kind/discussion Topical discussion; usually not changes to codebase label Mar 21, 2019
@jamiew
Copy link
Contributor Author

jamiew commented Dec 18, 2019

I'd like to get rid of this; the older ipfg bash script https://github.com/JayBrown/Tools/blob/master/ipfg/ipfg also has a newer golang version that doesn't rely on lastpubver as a cache key: https://github.com/gingerhot/ipfg

I haven't tested it but even the bash ipfg doesn't seem to absolutely expect that file either

@SgtPooki
Copy link
Member

closing this as we no longer use lastpubver. see #194 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants