Opt-out from gateway redirects done by IPFS Companion #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Jul 2, 2018
| @@ -27,7 +27,9 @@ function checkGateways (gateways) { | |||
| let checked = 0 | |||
| gateways.forEach((gateway) => { | |||
| const gatewayAndHash = gateway.replace(':hash', hashToTest) | |||
| fetch(gatewayAndHash) | |||
| // opt-out from gateway redirects done by browser extension | |||
| const testUrl = gatewayAndHash + '#x-ipfs-companion-no-redirect' | |||
There was a problem hiding this comment.
@victorbjelkholm FYI this feature shipped to Beta in ipfs-companion/releases/tag/v2.4.0.10120
|
FYSA support for redirect opt-out via |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our browser extension redirects request to gateways, which breaks this status page. Additionally, due to a workaround for CORS bug in Firefox it produces different results under Chrome and Firefox.
TL;DR we don't want browser extension to touch requests made by public-gateway-checker
This PR adds an explicit opt-out hint that ensures test requests reach the right gateway.
More info about opt-out URL hint: ipfs/ipfs-companion#505
(to be released with next version of browser extension)
cc @victorbjelkholm